Skip to content

update wrangler's pnpm dev to also watch the containers-shared src directory #9844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

dario-piotrowicz
Copy link
Member

wrangler imports files from the containers-shared package (which does not have a build/dev command itself), so the wrangler dev command needs to also watch the containers-shared directory to make sure that changes to files in such directory trigger appropriate wrangler rebuilds


  • Tests
    • Tests included
    • Tests not necessary because: infra change
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: infra change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: unrelated to wrangler v3

…directory

wrangler imports files from the containers-shared package (which does not have a build/dev command itself), so the wrangler dev command needs to also watch the containers-shared directory to make sure that changes to files in such directory trigger appropriate wrangler rebuilds
Copy link

changeset-bot bot commented Jul 3, 2025

⚠️ No Changeset found

Latest commit: 6a89930

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jul 3, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9844

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9844

miniflare

npm i https://pkg.pr.new/miniflare@9844

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9844

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9844

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9844

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9844

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9844

wrangler

npm i https://pkg.pr.new/wrangler@9844

commit: 6a89930

@dario-piotrowicz dario-piotrowicz added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jul 3, 2025
Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this!

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 4, 2025
@dario-piotrowicz dario-piotrowicz added this pull request to the merge queue Jul 4, 2025
Merged via the queue into main with commit c32bb35 Jul 4, 2025
43 of 46 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/wrangler-dev-watch-containers-shared branch July 4, 2025 14:46
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants