Skip to content

fix: use logger (and log level) from miniflare for asset metadata parsing/loading logs #9855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Jul 4, 2025

Fixes #9809


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: Workers assets are not backported

@petebacondarwin petebacondarwin requested a review from a team as a code owner July 4, 2025 13:12
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jul 4, 2025
Copy link

pkg-pr-new bot commented Jul 4, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9855

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9855

miniflare

npm i https://pkg.pr.new/miniflare@9855

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9855

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9855

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9855

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9855

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9855

wrangler

npm i https://pkg.pr.new/wrangler@9855

commit: 8cc338c

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 4, 2025
@petebacondarwin petebacondarwin force-pushed the pbd/reuse-miniflare-logger-when-parsing-assets-metadata branch from 7e7b8af to 8cc338c Compare July 4, 2025 15:16
Copy link

changeset-bot bot commented Jul 4, 2025

🦋 Changeset detected

Latest commit: 8cc338c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin enabled auto-merge July 4, 2025 15:42
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 4, 2025
Merged via the queue into main with commit 6f344bf Jul 4, 2025
32 checks passed
@petebacondarwin petebacondarwin deleted the pbd/reuse-miniflare-logger-when-parsing-assets-metadata branch July 4, 2025 19:58
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 4, 2025
@workers-devprod workers-devprod mentioned this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

--log-level=none is ignored by worker static assets headers
3 participants