Skip to content

fix c3 cli e2e test on forks #9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Jul 4, 2025

It turns out that when Github blocks env vars on forks it only wipes them (turns them to empty strings) rather than making them undefined.

Best reviewed with whitespace changes off.

@petebacondarwin petebacondarwin requested review from a team as code owners July 4, 2025 15:40
@petebacondarwin petebacondarwin added skip-pr-description-validation Skip validation of the required PR description format no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR labels Jul 4, 2025
Copy link

changeset-bot bot commented Jul 4, 2025

⚠️ No Changeset found

Latest commit: 1944882

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jul 4, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9860

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9860

miniflare

npm i https://pkg.pr.new/miniflare@9860

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9860

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9860

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9860

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9860

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9860

wrangler

npm i https://pkg.pr.new/wrangler@9860

commit: 1944882

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 4, 2025
@petebacondarwin petebacondarwin enabled auto-merge July 4, 2025 15:49
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 4, 2025
Merged via the queue into main with commit eb542d9 Jul 4, 2025
45 of 49 checks passed
@petebacondarwin petebacondarwin deleted the pbd/c3/fix-cli-e2e-on-forks branch July 4, 2025 16:07
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changeset-required skip-pr-description-validation Skip validation of the required PR description format skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants