Skip to content

update get-platform-proxy remote-bindings fixture to use vitest for consistency #9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dario-piotrowicz
Copy link
Member

Most of the fixtures use vitest as the test runner, this is not the case for the get-platform-proxy-remote-bindings-node-test fixture, so here I am updating the fixture to use vitest for consistency with the others


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tests change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: changes to tests not present in the v3 branch

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner July 7, 2025 09:47
@dario-piotrowicz dario-piotrowicz added no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR labels Jul 7, 2025
Copy link

changeset-bot bot commented Jul 7, 2025

⚠️ No Changeset found

Latest commit: b3859b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jul 7, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9868

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9868

miniflare

npm i https://pkg.pr.new/miniflare@9868

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9868

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9868

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9868

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9868

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9868

wrangler

npm i https://pkg.pr.new/wrangler@9868

commit: b3859b0

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 7, 2025
@petebacondarwin petebacondarwin enabled auto-merge July 7, 2025 10:21
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 7, 2025
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 1beec14 Jul 7, 2025
43 of 46 checks passed
@petebacondarwin petebacondarwin deleted the dario/get-platform-proxy-remote-bindings-vitest branch July 7, 2025 10:59
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants