Skip to content

Make error message for containers images delete more helpful. #9875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gpanders
Copy link
Member

@gpanders gpanders commented Jul 7, 2025

Fixes CC-5181.

Print the expected format to make it clear(er) to users that the argument must be of the form IMAGE:TAG.

Also update the error handling for some of the images subcommands so that they properly print errors and exit with a non-zero status code in error cases.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: UX change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: do not backport containers changes

@gpanders gpanders requested review from a team as code owners July 7, 2025 18:32
Copy link

changeset-bot bot commented Jul 7, 2025

🦋 Changeset detected

Latest commit: 9355d89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Print the expected format to make it clear(er) to users that the
argument must be of the form IMAGE:TAG.

Also update the error handling for some of the images subcommands so
that they properly print errors and exit with a non-zero status code in
error cases.
@gpanders gpanders force-pushed the push-wpsrpmywrvyp branch from 93ce23e to e41c3cc Compare July 7, 2025 18:32
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main push-wpsrpmywrvyp might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9875
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

Copy link

pkg-pr-new bot commented Jul 7, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9875

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9875

miniflare

npm i https://pkg.pr.new/miniflare@9875

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9875

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9875

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9875

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9875

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9875

wrangler

npm i https://pkg.pr.new/wrangler@9875

commit: 9355d89

@petebacondarwin petebacondarwin added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jul 7, 2025
@petebacondarwin
Copy link
Contributor

I added the skip-v3-pr label because containers stuff does not get backported to v3

@gpanders gpanders requested a review from petebacondarwin July 8, 2025 17:45
@gpanders gpanders requested a review from a team July 9, 2025 13:51
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

4 participants