Skip to content

Containers-shared: Remove undici dependency #9888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

Conversation

IRCody
Copy link
Contributor

@IRCody IRCody commented Jul 8, 2025

As far as I can tell undici is un-used anywhere by containers or cloudchamber so is safe to just remove.

  • Tests
    • Tests included
    • Tests not necessary because: Removing unused depdency
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Not externally visible behavior changes
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: packages doesn't exist in v3

@IRCody IRCody requested review from CarmenPopoviciu and a team July 8, 2025 19:41
Copy link

changeset-bot bot commented Jul 8, 2025

🦋 Changeset detected

Latest commit: e8bab5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/containers-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IRCody IRCody added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jul 8, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jul 8, 2025
Copy link

pkg-pr-new bot commented Jul 8, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9888

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9888

miniflare

npm i https://pkg.pr.new/miniflare@9888

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9888

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9888

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9888

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9888

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9888

wrangler

npm i https://pkg.pr.new/wrangler@9888

commit: e8bab5a

@IRCody IRCody removed request for a team and CarmenPopoviciu July 8, 2025 19:44
@IRCody IRCody force-pushed the cdr/remove-undici branch from 384d226 to 181206f Compare July 8, 2025 20:03
@IRCody IRCody force-pushed the cdr/remove-undici branch from 181206f to e8bab5a Compare July 8, 2025 20:04
@IRCody IRCody requested review from CarmenPopoviciu and a team July 8, 2025 20:22
@IRCody IRCody marked this pull request as ready for review July 8, 2025 20:22
@IRCody IRCody requested a review from a team as a code owner July 8, 2025 20:22
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 9, 2025
@CarmenPopoviciu CarmenPopoviciu added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@CarmenPopoviciu CarmenPopoviciu added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@emily-shen emily-shen added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@emily-shen emily-shen added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@lrapoport-cf lrapoport-cf added this pull request to the merge queue Jul 9, 2025
@edmundhung edmundhung removed this pull request from the merge queue due to the queue being cleared Jul 9, 2025
@emily-shen emily-shen merged commit d2fe58b into main Jul 9, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 9, 2025
@emily-shen emily-shen deleted the cdr/remove-undici branch July 9, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants