Skip to content

Emily/ci 9765 #9890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Emily/ci 9765 #9890

wants to merge 2 commits into from

Conversation

emily-shen
Copy link
Contributor

Fixes #[insert GH or internal issue link(s)].

Describe your change...


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because:
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because:

gpanders and others added 2 commits July 8, 2025 12:24
This allows us to build containers in dry run mode. When we push the
container to the managed registry, we re-tag it to include the account
ID. We only ever push when not in dry run mode though, so when pushing
we can safely grab the account information.

Co-authored-by: Hasip Timurtaş <[email protected]>
Even in dry run mode we should check that Docker is installed, because
dry run mode uses docker commands too.
@emily-shen emily-shen requested review from a team as code owners July 8, 2025 20:29
Copy link

changeset-bot bot commented Jul 8, 2025

🦋 Changeset detected

Latest commit: ec6bd2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 8, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/ci-9765 might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9890
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

Copy link

pkg-pr-new bot commented Jul 8, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9890

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9890

miniflare

npm i https://pkg.pr.new/miniflare@9890

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9890

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9890

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9890

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9890

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9890

wrangler

npm i https://pkg.pr.new/wrangler@9890

commit: ec6bd2e

@emily-shen emily-shen added skip-pr-description-validation Skip validation of the required PR description format skip-v3-pr Skip validation of presence of a v3 backport PR labels Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-pr-description-validation Skip validation of the required PR description format skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants