Skip to content

perf: increase binary search experiment sample rate to 50% #9892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

GregBrimble
Copy link
Contributor

@GregBrimble GregBrimble commented Jul 9, 2025

Related to #9852 which introduced the original binary search experiment.

Increase the binary search experiment sample rate from 5% to 50% to gather more performance data on the optimized implementation.

This change will allow us to collect more comprehensive performance metrics on the optimized binary search implementation.

/cc @vicb


🤖 Generated with Claude Code

Increase the binary search experiment sample rate from 5% to 50% to gather more performance data on the optimized implementation.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@GregBrimble GregBrimble requested review from a team as code owners July 9, 2025 02:55
Copy link

changeset-bot bot commented Jul 9, 2025

🦋 Changeset detected

Latest commit: 6900040

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jul 9, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9892

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9892

miniflare

npm i https://pkg.pr.new/miniflare@9892

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9892

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9892

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9892

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9892

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9892

wrangler

npm i https://pkg.pr.new/wrangler@9892

commit: 6900040

"@cloudflare/workers-shared": patch
---

perf: increase binary search experiment sample rate to 50%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... I hadn't added a changeset on #9852 thinking I would add one once and if the new implementation is merged I should probably have added once anyway.

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the PR and all the help with the implementation and the rollout. I highly appreciate!

@GregBrimble GregBrimble added this pull request to the merge queue Jul 9, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@vicb vicb added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@GregBrimble GregBrimble added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@GregBrimble GregBrimble added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@GregBrimble GregBrimble added this pull request to the merge queue Jul 9, 2025
@edmundhung edmundhung removed this pull request from the merge queue due to the queue being cleared Jul 9, 2025
@GregBrimble GregBrimble merged commit 78e259a into main Jul 9, 2025
37 of 40 checks passed
@GregBrimble GregBrimble deleted the perf-experiment-50-percent branch July 9, 2025 13:52
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants