-
Notifications
You must be signed in to change notification settings - Fork 925
perf: increase binary search experiment sample rate to 50% #9892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Increase the binary search experiment sample rate from 5% to 50% to gather more performance data on the optimized implementation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🦋 Changeset detectedLatest commit: 6900040 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
"@cloudflare/workers-shared": patch | ||
--- | ||
|
||
perf: increase binary search experiment sample rate to 50% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops... I hadn't added a changeset on #9852 thinking I would add one once and if the new implementation is merged I should probably have added once anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the PR and all the help with the implementation and the rollout. I highly appreciate!
Related to #9852 which introduced the original binary search experiment.
Increase the binary search experiment sample rate from 5% to 50% to gather more performance data on the optimized implementation.
This change will allow us to collect more comprehensive performance metrics on the optimized binary search implementation.
/cc @vicb
🤖 Generated with Claude Code