Skip to content

call resetDimensions on Text when we update the label #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

call resetDimensions on Text when we update the label #146

wants to merge 3 commits into from

Conversation

zgalant
Copy link
Member

@zgalant zgalant commented Nov 17, 2022 •
edited
Loading

call resetDimensions on Text when we update the label with setText or setLabel.

fixes #145

Summary

Fixes a bug that doesn't reset the dimensions of a Text object when we change the label.

Checklist

  • npm test passes
  • Unit tests are included / updated
  • Documentation has been updated where relevant (n/a - it's behind the scenes)

Once this goes live and is imported into the CodeHS repo, we can test at https://codehs.com/sandbox/id/texttester-NWPhxW

@zgalant zgalant mentioned this pull request Nov 17, 2022
Merged
3 tasks
@zgalant zgalant closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling setText is not resetting the dimensions of the text object
1 participant
@zgalant