Fix nudging for students (100%) #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2024 13:38
willm0602
force-pushed
the
will-fix-pushing
branch
from
4a086ce to
2f10edd
Compare
added 2 commits
May 9, 2024 14:29
| var FIREBASE_URL = 'https://live-dashboard-d4d0e-default-rtdb.firebaseio.com/'; | ||
| var refPath = isLocal ? 'LOCAL_NAV/' : 'LIVE_NAV/'; | ||
| refPath += userID; | ||
| var firebaseApp = initializeApp({ |
There was a problem hiding this comment.
we might need to be careful here - if firebase is already on the window this can cause issues. lets hold off for now and talk about it, maybe we can loop in @john-kelly as well
added 2 commits
June 24, 2024 12:08
almeidaalajoel
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue where nudging students using RTG slides wasn't working since we didn't have focus working for the SJR app. We normally have it called from the
main.jsbundle in the main codehs app, so this uses the same logic to get realTime working to enforce students to stay on their site by nuding them back to the URL from their firebase instance when it's changedLoom demo:
https://www.loom.com/share/95fcde9540124561abca52491632bb10?sid=91a7a23b-bd7f-43f6-99fe-8169f0a48517