Skip to content

fix: rector #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix: rector #1248

merged 1 commit into from
Feb 11, 2025

Conversation

michalsn
Copy link
Member

Description
This PR ignores two Rector rules which were added in the latest versions.

I believe that the application of these rules will negatively affect the readability of our tests.

Here are the proposed changes in the codebase by Rector: https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890

I'm not super convinced about it - this was just my first impression.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb
Copy link
Collaborator

I see this change as fair and reasonable.

@michalsn michalsn merged commit 58d6d6f into codeigniter4:develop Feb 11, 2025
28 checks passed
@michalsn
Copy link
Member Author

Thanks for the review guys!

@michalsn michalsn deleted the fix/rector branch February 11, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@datamweb datamweb datamweb approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis Awaiting requested review from kenjis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalsn @datamweb @samsonasik @paulbalandan