Skip to content

refactor: improve expiration time calculation using addSeconds() #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

refactor: improve expiration time calculation using addSeconds() #1256

merged 1 commit into from
Feb 28, 2025

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Feb 27, 2025 •
edited
Loading

Description
Improve expiration time calculation using addSeconds()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb
Refactor: improve expiration time calculation using addSeconds()
481c431 
Improve expiration time calculation using `addSeconds()`
@datamweb datamweb added the refactor Pull requests that refactor code label Feb 27, 2025
@datamweb
Copy link
Collaborator Author

@michalsn Thank you for the review! I really appreciate your feedback. 😊

@datamweb datamweb merged commit 57d5d5c into develop Feb 28, 2025
36 of 37 checks passed
@datamweb datamweb deleted the refactor-by-addSeconds branch February 28, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datamweb @michalsn