fix bug in show-hints inset #7129
Open
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a minimal HTML page that shows the current issue happening? My response to the issue you linked suggests I haven't been able reproduce the issue. |
alirrah
force-pushed
the
hints-inset-position
branch
2 times, most recently
from
aca92ea to
0a88b8c
Compare
alirrah
force-pushed
the
hints-inset-position
branch
from
0a88b8c to
75f56c3
Compare
|
You can see the error at the link below: As can be seen in line 272, the value of offsetTop should be subtracted from top, whereas in line 294 it has been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the show-hints box does not have space to be displayed below, the box will be displayed in the wrong place, which is also reported in this issue. I fixed this issue by making some changes, which you can see in the videos below.
The reason I added
marginBottomis so that I can give the box some space from the bottom (I didn't want the box to stick to the bottom of the page).before:
vokoscreenNG-2025-06-24_09-52-21.webm
after:
vokoscreenNG-2025-06-24_09-49-06.webm