-
Notifications
You must be signed in to change notification settings - Fork 3
Control automatic port forwarding with a devcontainer.json file #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bcpeinhardt
merged 9 commits into
coder:main
from
aaronlehmann:ports-from-devcontainer-json
Feb 27, 2025
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
12f38a1
Control automatic port forwarding with a devcontainer.json file
aaronlehmann ae1df2f
Validate single port or range endpoint is between 0 and 65535
aaronlehmann 933e1d4
Split devcontainer.json file path out to a settings module
aaronlehmann cf25cbe
Add validation that onAutoForward is a string
aaronlehmann 69432d7
PortMatcher code review feedback
aaronlehmann 3433d28
Use kotlinx.serialization for JSON deserialization
aaronlehmann 2da0908
Add comment about switching kotlinx-serialization-json to compileOnly
aaronlehmann 8d86ee7
Merge branch 'main' into ports-from-devcontainer-json
bcpeinhardt fa0df63
changelog
bcpeinhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Validate single port or range endpoint is between 0 and 65535
- Loading branch information
commit ae1df2f2eaf898fba7d011488b8cc37c0053f82f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non Blocking Nit/Question: Should we validate the port is between 0 and 65535 for the SinglePort and PortRange parsing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this validation