feat: custom users tab #44
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "$schema": "https://biomejs.dev/schemas/2.0.6/schema.json" |
There was a problem hiding this comment.
I don't see a matching package.json version bump. do we not have biome as a dev dependency?
| @@ -0,0 +1 @@ | |||
|
|
|||
| "experimentalScannerIgnores": [ | ||
| "src/client/gen/types.ts", |
There was a problem hiding this comment.
I don't think this is what we want to use here. The docs say the new replacement for files.ignore is actually...
{
"files": {
"include": ["!src/client/gen/types.ts"]
}
}(note the ! in there)
| @@ -30,46 +30,35 @@ | |||
| "level": "off" | |||
| }, | |||
| "noParameterAssign": { | |||
| "level": "off" | |||
| "level": "off", | |||
| "options": {} | |||
There was a problem hiding this comment.
feels weird to specify options for "off"
| }, | ||
| "useDefaultParameterLast": { | ||
| "level": "off" | ||
| }, | ||
| "useSelfClosingElements": { | ||
| "level": "off" | ||
| "level": "off", | ||
| "options": {} |
| @@ -101,6 +84,14 @@ export const App = () => { | |||
| ); | |||
| }; | |||
|
|
|||
| useEffect(() => { | |||
| const newCurrentUser = users.find((u) => u.id === currentUser.id); | |||
|
|
|||
| const selectedMissing = !users.some( | ||
| (owner) => currentUser.id === owner.id, | ||
| ); |
There was a problem hiding this comment.
| const selectedMissing = !users.some( | |
| (owner) => currentUser.id === owner.id, | |
| ); | |
| const selectedMissing = users.every((owner) => currentUser.id !== owner.id); |
these should be equivalent, but this seems a tiny bit clearer to me
| {users.map((owner, index) => ( | ||
| <SelectItem value={owner.id} key={index}> | ||
| {owner.full_name || owner.name} | ||
| </SelectItem> | ||
| ))} |
There was a problem hiding this comment.
does this mean currentUser gets shown twice?
| @@ -60,7 +61,10 @@ app.get("/parameters/:shareId?/:example?", async (c, next) => { | |||
| </head> | |||
| <body> | |||
| <div id="root"></div> | |||
| <script type="module">{`window.CODE = ${JSON.stringify(exampleCode)}`}</script> | |||
| <script type="module">{`window.CODE = ${JSON.stringify(codeAndUsers.code)}`}</script> | |||
| {codeAndUsers.users ? ( | |||
There was a problem hiding this comment.
nit: could probably be an &&, since the "else" here isn't anything important.
| @@ -0,0 +1,21 @@ | |||
| export const downloadData = (data: unknown, fileName: string) => { | |||
There was a problem hiding this comment.
I love how janky the web platform is. thanks for moving it out into a function. 😄
Closes #40