Skip to content

Exception thrown during shutdown #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Exception thrown during shutdown #15

wants to merge 1 commit into from

Conversation

bmadzar
Copy link

@bmadzar bmadzar commented Mar 10, 2015

This is a pull request for bug 69131

  • If a strong reference is acquired but not freed and the Weakref instance is destroyed, an exception is thrown during shutdown (Failed to correctly release...) The Weakref instance is in an inconsistent state: valid is 0 but acquired is > 0.
  • This causes PHP not to clean up after the request correctly
  • The next request (FPM SAPI) errors out with a cryptic error message as some of the state from the previous request hasn't been cleaned up
  • Eventually the FPM child process dies (SIGSEGV)

I've patched the destructor to release any strong references before setting valid to 0. This seems to fix the issue, though there might be something I'm missing.

Exception thrown during shutdown if acquired references are not released before Weakref instance is destroyed
@bmadzar bmadzar changed the title Exception thrown during shutdown if acquired references are not released before Weakref instance is destroyed Exception thrown during shutdown Mar 10, 2015
@bmadzar
Copy link
Author

bmadzar commented Jan 14, 2016

Fixed

@bmadzar bmadzar closed this Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant