Fix duplicate symbol errors on LLVM (MacOS) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colder
added a commit
that referenced
this pull request
Nov 5, 2012
Fix duplicate symbol errors on LLVM (MacOS)
|
Thanks for this! I had no idea it could cause troubles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the variable definitions being in the header files and included from both wr_weakref/wr_weakmap and php_weakref, there are several duplicate symbol errors that aren't automatically resolved with llvm:
duplicate symbol _wr_ce_WeakRef in:
.libs/php_weakref.o
.libs/wr_weakref.o
duplicate symbol _wr_handler_WeakRef in:
.libs/php_weakref.o
.libs/wr_weakref.o
duplicate symbol _weakref_globals in:
.libs/php_weakref.o
.libs/wr_weakref.o
duplicate symbol _wr_ce_WeakMap in:
.libs/php_weakref.o
.libs/wr_weakmap.o
duplicate symbol _wr_handler_WeakMap in:
.libs/php_weakref.o
.libs/wr_weakmap.o
duplicate symbol _wr_handler_WeakRef in:
.libs/php_weakref.o
.libs/wr_weakmap.o
duplicate symbol _wr_ce_WeakRef in:
.libs/php_weakref.o
.libs/wr_weakmap.o
duplicate symbol _weakref_globals in:
.libs/php_weakref.o
.libs/wr_weakmap.o