Skip to content

Honda: Car Port for Thai HR-V 2023 (3G) #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AlexandreSato
Copy link
Contributor

@AlexandreSato AlexandreSato commented Jun 8, 2025

Validation

  • Dongle ID: 1e4baee1aa2687a0
  • Route: 1e4baee1aa2687a0/00000001--74c4cc0b23
  • User: somkanae#5442

reference PR #27915
Thai HR-V 3G use ALT_GEAR msgs

@github-actions github-actions bot added car related to opendbc/car/ honda labels Jun 8, 2025
@vanillagorillaa
Copy link
Contributor

I think there is an easier way to do this. You can get rid of setting the safety flag in values.py, change interface to put the checks with the rest of the gearbox message checks (lines 69-77), set this car transmission as a cvt, then you can just include this vehicle with the Civic gearbox check in carstate.py

@sshane
Copy link
Contributor

sshane commented Jun 9, 2025

Is this ready for review? If the under braking stopping behavior still happens, can you leave a simple comment about this model of HR-V?

@AlexandreSato
Copy link
Contributor Author

AlexandreSato commented Jun 9, 2025

Is this ready for review? If the under braking stopping behavior still happens, can you leave a simple comment about this model of HR-V?

Last changes suggested by VanilaGorila not tested yet. That braking behavior only happens in the ACC stock of the Brazilian model. Op long doesn't happen.
What sonkanae was getting was HDC errors (descent control) but from what I understood from what he wrote in discord is that with a new official harness the HDC errors stopped
IMG_2606

@AlexandreSato AlexandreSato marked this pull request as ready for review June 10, 2025 20:58
@somkanae
Copy link

Is this ready for review? If the under braking stopping behavior still happens, can you leave a simple comment about this model of HR-V?

Last changes suggested by VanilaGorila not tested yet. That braking behavior only happens in the ACC stock of the Brazilian model. Op long doesn't happen. What sonkanae was getting was HDC errors (descent control) but from what I understood from what he wrote in discord is that with a new official harness the HDC errors stopped IMG_2606

Three years ago, I bought a comma 3. The Honda Bosch B harness wasn't officially out yet, so I re-pinned a comma harness myself. It worked, but I kept getting a hill descent error. Once comma released the official Honda Bosch B harness, I bought it, and I haven't had any issues since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ honda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants