-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Honda: Car Port for Thai HR-V 2023 (3G) #2381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Honda: Car Port for Thai HR-V 2023 (3G) #2381
Conversation
I think there is an easier way to do this. You can get rid of setting the safety flag in values.py, change interface to put the checks with the rest of the gearbox message checks (lines 69-77), set this car transmission as a cvt, then you can just include this vehicle with the Civic gearbox check in carstate.py |
Is this ready for review? If the under braking stopping behavior still happens, can you leave a simple comment about this model of HR-V? |
Validation
reference PR #27915
Thai HR-V 3G use ALT_GEAR msgs