HKG CANFD Signals: Fixes a miscalculation on 437 and adds descriptions to all signals found #2392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devtekve
changed the title
devtekve
changed the title
devtekve
commented
Jun 12, 2025
| CM_ SG_ 437 Info_RtLnPosVal "This signal outputs the position of right line from camera center."; | ||
| CM_ SG_ 437 Info_RtLnHdingAnglVal "This signal outputs the heading angle of right line."; | ||
| CM_ SG_ 437 Info_RtLnCvtrVal "This signal outputs the curvature of right line."; | ||
| CM_ SG_ 437 ID_CIPV "Valid Object = 1 to 127 - ID detected by front camera can vary depending on vehicle environment. - Additional logic would be required to apply this signal for ISG. - Confirmaiton by Autonomous Driving Engineering Team is required to use ID_CIPV signa"; |
There was a problem hiding this comment.
The original message I found was explicit to being 7bits (from 1 to 127). But given the comment at the end of this signal, Seems like it might've been too early on development and then it evolved to 8 bits, which seems more consistent with the observations.
If you agree with this assessment, feel free to include this change suggestion and merge
Suggested change
| CM_ SG_ 437 ID_CIPV "Valid Object = 1 to 127 - ID detected by front camera can vary depending on vehicle environment. - Additional logic would be required to apply this signal for ISG. - Confirmaiton by Autonomous Driving Engineering Team is required to use ID_CIPV signa"; | |
| CM_ SG_ 437 ID_CIPV "Valid Object = 1 to 255 - ID detected by front camera can vary depending on vehicle environment. - Additional logic would be required to apply this signal for ISG."; |
There was a problem hiding this comment.
what do you think is correct? I don't see any routes to review
|
What port PR does this support? |
sshane
reviewed
Jun 13, 2025
Comment on lines
+673
to
+690
| CM_ SG_ 282 FR_CMR_Crc1Val "The data area for CRC calculation is based on the data length (DLC) of the message DB. The CRC shall be calculated over the entire data block (excluding the CRC bytes) including the user data, alive counter and Data ID - CRC Polynomial (0x1021) , In"; | ||
| CM_ SG_ 282 FR_CMR_AlvCnt1Val "For the first transmission request for a data element the counter shall be initialized with 0 and shall be incremented by 1 for every subsequent send request. When the counter reaches the maximum value(0xFF), then it shall restart with 0 for the next s"; | ||
| CM_ SG_ 282 HBA_SysOptSta "HBA System Option Information to Lamp Controller"; | ||
| CM_ SG_ 282 HBA_SysSta "This signal indicates the status of High Beam Assist system."; | ||
| CM_ SG_ 282 HBA_IndLmpReq "HBA System Indicator Lamp Status"; | ||
| CM_ SG_ 282 FCA_Equip_MFC "FCA Sensor Type"; | ||
| CM_ SG_ 282 HBA_OptUsmSta "HBA Option USM Status"; | ||
| CM_ SG_ 282 DAW_LVDA_PUDis "Message for displaying LVDA(Leading Vehicle Departure Alert) Warning"; | ||
| CM_ SG_ 282 DAW_LVDA_OptUsmSta "LVDA USM state"; | ||
| CM_ SG_ 282 DAW_OptUsmSta "This signal represents the lastest DAW ON/OFF value of USM."; | ||
| CM_ SG_ 282 DAW_SysSta "This signal represents Attention Assist System Status or Attention Level."; | ||
| CM_ SG_ 282 DAW_WrnMsgSta "0x1 value requests DAW Rest recommend warning message popup at CLU. 0x2 value requests HDA/LFA Hands-Off call at TMS."; | ||
| CM_ SG_ 282 DAW_TimeRstReq "This signal requests CLU 'Last Break Time' Reset. DAW send '0x1' when detecting driver's rest."; | ||
| CM_ SG_ 282 DAW_SnstvtyModRetVal "This signal represents the feedback value of the current ADAS warning timing."; | ||
| CM_ SG_ 282 FR_CMR_SCCEquipSta "This signal indicates equipment for SCC"; | ||
| CM_ SG_ 282 FR_CMR_ReqADASMapMsgVal "This signal indicates an ADAS map message request from FR_CMR to H_U. Each bit indicates the request messages as follows. - Bit 0 : H_U_NAVI_V2_STUB_E - Bit 1 : HU_NAVI_V2_PROSHORT_E_00 (곡률) - Bit 2 : HU_NAVI_V2_PROSHORT_E_00 (곡률 외 정보)"; | ||
| CM_ SG_ 282 FR_CMR_SwVer1Val "This signal indicates a major version of FR_CMR software. If FR_CMR software version is A.00, 'A' and '00' mean major and minor version respectively."; | ||
| CM_ SG_ 282 FR_CMR_SwVer2Val "This signal indicates a minor version of FR_CMR software. If FR_CMR software version is A.00, 'A' and '00' mean major and minor version respectively."; |
There was a problem hiding this comment.
I meant message name comments, but these are great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2317 (comment) and also fixes a wrong signal
ID_CIPVwhere I set it to 7bits but it seems to be 8bits. Thanks @royjr for pointing that out.Note
The descriptions are kept as found on the original DBC. I only removed the breaklines to have them as one-liners