Skip to content

IE8 Support #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

IE8 Support #159

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fe960bc
Dont process removed nodes
Sep 4, 2014
2dfe287
dont interpolate removed text nodes
Sep 4, 2014
a70d217
Add test for data-html replacing text
Sep 4, 2014
711e28e
Make tests IE9 compatible (type=email doesnt work, so use set/getAttr…
Sep 4, 2014
7c85d67
IE8 Support
Sep 4, 2014
a189c37
Update ie8 shims
Sep 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dont interpolate removed text nodes
  • Loading branch information
Jon Eisen committed Sep 4, 2014
commit 2dfe287f79f4aeb8891c07689ea4f944b5c0699a
5 changes: 1 addition & 4 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,6 @@ Reactive.prototype._bind = function() {
var bindings = self.bindings;

walk(self.el, function(el, next) {
if (!el.parentNode) // Don't process removed nodes
return next()

// element
if (el.nodeType == 1) {
var skip = false;
Expand Down Expand Up @@ -269,7 +266,7 @@ Reactive.prototype._bind = function() {
return next(skip);
}
// text
else if (el.nodeType == 3) {
else if (el.nodeType == 3 && el.parentNode) {
if (utils.hasInterpolation(el.data)) {
debug('bind text "%s"', el.data);
new TextBinding(self, el);
Expand Down