Disambiguate and simplify pin logic #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tealefristoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disambiguates and simplifies the logic used to determine if a pin is shown or not.
pinLatitude,pinLongitude, andpinElevationare used to determine the location of the pin, rather than reusingventLatitudeandventLongitude.showPinflag is added to theLavaSimulationStore. When this is true, the pin is shown. When it is false, the pin isn't shown.showPinis only set to true when the user clicks to drop a pin.showPinis set to false when the simulation starts.It would be better to remove the pin information from
LavaSimulationStoreand added toUIStoreor perhaps a newLavaUIStore, but I didn't bother with that for now. I left a TODO comment about doing this in the future.