Skip to content

Manifest lists with manifests of different mediaType should be valid #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whatsacomputertho opened this issue May 7, 2025 · 7 comments
Assignees
Labels
bug v1.0.0-beta.1 Features & bug fixes to be released in version 1.0.0-alpha.1

Comments

@whatsacomputertho
Copy link
Collaborator

This is an observation made as resolving a previous bug

If we get an OCI index back from the registry that contains docker v2 manifests, then we consider that an invalid schema. Other clients out there like skopeo do not impose such a heavy-handed check. We should soften this check and enable OCI indices to contain docker v2 manifests, and vice versa, docker v2s2 manifest lists to contain OCI manifests.

@whatsacomputertho whatsacomputertho self-assigned this May 7, 2025
@whatsacomputertho whatsacomputertho added bug v1.0.0-beta.1 Features & bug fixes to be released in version 1.0.0-alpha.1 labels May 7, 2025
@whatsacomputertho
Copy link
Collaborator Author

FYI @cmoulliard @matejvasek

@whatsacomputertho
Copy link
Collaborator Author

Moved to in-progress as I plan to (hopefully) work on this today

@whatsacomputertho
Copy link
Collaborator Author

Moving out of in-progress as I didn't get to this during the weekend. I may get to it this week, we'll see how the work schedule pans out

@whatsacomputertho
Copy link
Collaborator Author

Moved back to in-progress. Working this now.

@whatsacomputertho
Copy link
Collaborator Author

@cmoulliard @matejvasek Here is the quick example now working with your ghcr.io image swapped in:

% python examples/quick-example.py
Size of ghcr.io/matejvasek/builder-ubi8-base:latest: 362.57 MB
Digest for ghcr.io/matejvasek/builder-ubi8-base:latest: sha256:701a398aa35bc8858f257eec8e0b8e3867b4f6abaec26f14d967aeb7a300b9a7

PR on its way soon for you to review.

@whatsacomputertho
Copy link
Collaborator Author

whatsacomputertho commented May 14, 2025

PR open now and passing all CI checks, ready for review

Moving this issue into review

@whatsacomputertho
Copy link
Collaborator Author

Going to go ahead and merge that PR now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug v1.0.0-beta.1 Features & bug fixes to be released in version 1.0.0-alpha.1
Projects
None yet
Development

No branches or pull requests

1 participant