Skip to content

fix(validation): do not enforce entry mediatypes #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

whatsacomputertho
Copy link
Collaborator

In this PR, I soften the check on manifest list entry mediaTypes. Previously in the v2s2 manifest list and OCI index validation logic I checked the list entries for whether their mediaTypes align with the parent list mediaType. I.e. if it's a v2s2 manifest list then it better not include OCI manifests, or vice versa. But it does not seem that the official containerization libraries make this assertation so I am comfortable softening this check.

This eliminates the final blocker for @matejvasek @cmoulliard to use this library to inspect the properties of their base image from ghcr.io.

For reference, see:

@whatsacomputertho
Copy link
Collaborator Author

Looks like unit tests expected that condition, may need to clean up some old asserts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant