fix use set more than once,will crash #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on twice, calling set (inconsistent piling functions twice), decomposing the instance of stub, or calling reset with the same instance of stub, restoring the previous function address is the function address of the first piling, not the original function address, which may cause crash and inconsistent with the expected result. Only the original address is saved every time.
|
Thanks, bug fixed. Modify to call reset() on each set(). #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that when using the same instance of stub, piling the same function twice, calling set (inconsistent piling functions twice), decomposing the instance of stub, or calling reset with the same instance of stub, restoring the previous function address is the function address of the first piling, not the original function address, which may cause crash and inconsistent with the expected result. Only the original address is saved every time.