use unsigned char* for the fn pointer type
#37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the type is just `char*`, I get a lot of -Woverflow warnings from the compiler
```
main.cpp:22:
cpp-stub/stub.h: In instantiation of ‘void Stub::set(T, S) [with T = int (*)(int); S = int (*)(int)]’:
main.cpp:42:17: required from here
cpp-stub/stub.h:209:21: error: overflow in conversion from ‘int’ to ‘char’ changes value from ‘187’ to ‘-69’ [-Werror=overflow]
209 | *(fn + 1) = 0xbb;\
| ^~~~
cpp-stub/stub.h:327:13: note: in expansion of macro ‘REPLACE_FAR’
327 | REPLACE_FAR(this, fn, fn_stub);
| ^~~~~~~~~~~
```
```
In file included from main.cpp:22:
cpp-stub/stub.h:276:28: error: cannot initialize a parameter of type 'char *' with an lvalue of type 'unsigned char *'
276 | CACHEFLUSH(pstub->fn, CODESIZE);
| ^~~~~~~~~
cpp-stub/stub.h:28:56: note: expanded from macro 'CACHEFLUSH'
28 | #define CACHEFLUSH(addr, size) __builtin___clear_cache(addr, addr + size)
| ^~~~
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the type is just
char*, I get a lot of -Woverflow warnings from the compiler