fix: CDataTable: set select default value to perPageItems if possible #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladyslav-kushnir
suggested changes
Nov 11, 2020
There was a problem hiding this comment.
Can you please add perPageItems as an additional option to the dropdown maybe in case it's missing from the paginationSelect.values list? You can do so by simply introducing bool flag before you go over collection with map and inside that map method setting it to true in case value is the same. Then after the whole map you can check if flag is false you simply add one more option. Hope that makes sense.
|
@Downsidelama |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CDataTable is being created with itemsPerPageSelect prop, it will always show the first item in the select's options.
There was a hidden option, which I removed and changed the default to perPageItems.
If there is no matching value in the array, then it will select the first from the options.