Changes to URI #11
Merged
Changes to URI #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llocator for a string.
…o make sure the builder correctly encodes a path.
| } | ||
|
|
||
| const char *uri_category_impl::name() const NETWORK_URI_NOEXCEPT { | ||
| const char *uri_category_impl::name() const noexcept { | ||
| static const char name[] = "uri_error"; |
There was a problem hiding this comment.
nit: have you considered turning this function into a constexpr function?
|
LGTM -- merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dean,
I made some breaking changes to the URI, but none of these changes should affect cpp-netlib adversely.
Most of the changes are a result of ongoing discussions I've had with the BSI C++ panel, attendees at ACCU at Bristol and the feedback I've had so far from the ISO committee.
The changes I've made ought to be clear from the commit messages, but please ask if anything isn't up to standard.