Skip to content

No need to test *_FOUND variable before find_package call #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2013

Conversation

ruslo
Copy link
Contributor

@ruslo ruslo commented Oct 22, 2013

From find_package documentation:
Once one of the calls succeeds the result variable will
be set and stored in the cache so that no call will search again.

From find_package documentation:
  Once one of the calls succeeds the result variable will
  be set and stored in the cache so that no call will search again.
@ruslo
Copy link
Contributor Author

ruslo commented Oct 22, 2013

BTW, here is drone.io build for test:
Build Status

@ghost ghost assigned glynos Oct 22, 2013
glynos added a commit that referenced this pull request Oct 22, 2013
No need to test *_FOUND variable before find_package call
@glynos glynos merged commit 3d9b0ce into cpp-netlib:master Oct 22, 2013
@glynos
Copy link
Member

glynos commented Oct 22, 2013

Thanks, and nice drone.io report!

@ruslo
Copy link
Contributor Author

ruslo commented Oct 22, 2013

Yep, there are a lot of noise around all this fresh boost and gcc versions (I failed to find appropriate clang + libcxx) but it works. You can get build script from here and set hooks to main repo

@ruslo ruslo deleted the find_package branch October 22, 2013 18:09
@glynos
Copy link
Member

glynos commented Oct 23, 2013

Looks good, but you don't need to install gcc, it will work if you set the
environment variables:

CC=gcc-4.8
CXX=g++-4.8

or

CC=clang
CXX=clang++

but it doesn't build if you use clang :S

On 22 October 2013 20:09, ruslo [email protected] wrote:

Yep, there are a lot of noise around all this fresh boost and gcc versions
(I failed to find appropriate clang + libcxx) but it works. You can get
build script from here https://drone.io/github.com/ruslo/uri/admin and
set hooks to main repo


Reply to this email directly or view it on GitHubhttps://github.com//pull/39#issuecomment-26827381
.

@ruslo
Copy link
Contributor Author

ruslo commented Oct 23, 2013

Looks good, but you don't need to install gcc, it will work if you set the environment variables: CC=gcc-4.8 CXX=g++-4.8

Fixed

@ruslo
Copy link
Contributor Author

ruslo commented Oct 23, 2013

Result of removing set(CMAKE_VERBOSE_MAKEFILE true) and use some /dev/null magic:
https://drone.io/github.com/ruslo/uri/44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants