Added a bunch of documentation and removed the noexcept operator from some accessors. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but... why the change from cppnetlib-uri to network-uri? |
|
Because it's more consistent with the namespace (network::uri) and the directory structure (network/uri.hpp) |
|
I'm not sure this is a good idea though. I thought about it a little more and the identifying information that this library is part of cpp-netlib is I think important. I'm merging this, and hoping we can revisit the decision later on when we have the HTTP server, client, and other protocols implemented appropriately. |
deanberris
added a commit
that referenced
this pull request
Dec 16, 2013
Added a bunch of documentation and removed the noexcept operator from some accessors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.