Allow for building with the Android NDK. #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use boost::lexical_cast instead of std::to_string and std::stoi functions - which aren't defined by android.
glynos
added a commit
that referenced
this pull request
Feb 1, 2015
Allow for building with the Android NDK.
|
Thanks, I'm satisfied with these changes. Out of interest, how are you building this library for Android? Don't you need to make any changes to the CMake files? |
|
I posted my answer on the mailing list...so that discussion can continue there - https://groups.google.com/forum/#!topic/cpp-netlib/vsqTPy9m3dE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use boost::lexical_cast instead of std::to_string and std::stoi functions - which aren't defined by android.
I'm not sure about the performance implications or the added dependency that comes with this change (boost::lexical_cast) - but it seems to be working pretty smoothly, and all the tests still pass.