Boost string ref #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| TEST(uri_test, DISABLED_full_uri_range_fragment_end_iterator_test) { | ||
| network::uri instance("http://user:[email protected]:80/path?query#fragment"); | ||
| //ASSERT_TRUE(std::end(instance) == std::end(*instance.fragment())); |
There was a problem hiding this comment.
Because the types return by end are different now. The tests marked as DISABLED should have been removed altogether.
There was a problem hiding this comment.
Can we remove these instead?
|
LGTM |
|
LGTM -- however I cannot merge this for some reason, I may not be an administrator of the URI repo. |
|
Your deanberris account was on the list of owners (only your old account was), try it again when you're ready. |
|
Thanks Glyn -- yes I see this now. I'll merge this and hope that the tests marked DISABLED are just removed later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
included in this PR are a small number of configuration changes, plus the uri class now uses boost::string_ref instead of our home-brewed version. The minimum boost version required now is 1.53.
It won't compile on the version of MSVC 2012 that I am using because it doesn't support explicit conversion operators.