Add support for HipChat API v2 #1049
Conversation
|
Hi @laszlof - Is there a reason we would need to keep support for the old API? Couldn't we just use the new one? |
|
Yes. The API's use different login credentials. Tokens that worked for the v1 API will not work for v2. That being said, you probably dont want to break any existing installations. |
| $message->setColor($this->color); | ||
| $message->setMessage($msg); | ||
| $message->setNotify($this->notify); | ||
|
|
There was a problem hiding this comment.
Avoid unused local variables such as '$return'.
There was a problem hiding this comment.
PHPCS: Line indented incorrectly; expected at least 16 spaces, found 14
|
We could really use this . Could you please make the build pass ? |
|
I'd love to, if I knew why the build was failing. Clicking details prompts me to login. |
|
Hey @dancryer , can you help us out ? |
|
Pretty clear this isnt getting merged. We're no longer using it anyways as it doesnt appear the maintainers care about keeping it up to date. Closing this to get it off my list. |
|
What are you using now @laszlof? |
|
Currently a mixed bag. Mostly Travis and Jenkins. |
This adds support for HipChat's API v2. The docs will need to be updated to include the v2Api configuration option. Tested and working in our environment.