Add auto-configuration for Thymeleaf data dialect

Closes spring-projects#1120

Author: Max Bruchmann

spring-boot-autoconfigure/pom.xml

@@ -290,6 +290,11 @@
 			<artifactId>thymeleaf-layout-dialect</artifactId>
 			<optional>true</optional>
 		</dependency>
+		<dependency>
+			<groupId>com.github.mxab.thymeleaf.extras</groupId>
+			<artifactId>thymeleaf-extras-data-attribute</artifactId>
+			<optional>true</optional>
+		</dependency>
 		<dependency>
 			<groupId>org.thymeleaf.extras</groupId>
 			<artifactId>thymeleaf-extras-springsecurity3</artifactId>

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/thymeleaf/ThymeleafAutoConfiguration.java

@@ -47,6 +47,8 @@
 import org.thymeleaf.templateresolver.ITemplateResolver;
 import org.thymeleaf.templateresolver.TemplateResolver;
 
+import com.github.mxab.thymeleaf.extras.dataattribute.dialect.DataAttributeDialect;
+
 /**
  * {@link EnableAutoConfiguration Auto-configuration} for Thymeleaf.
  *
@@ -66,20 +68,20 @@ public class ThymeleafAutoConfiguration {
 
 	@Configuration
 	@ConditionalOnMissingBean(name = "defaultTemplateResolver")
-	public static class DefaultTemplateResolverConfiguration  {
+	public static class DefaultTemplateResolverConfiguration {
 
 		@Autowired
 		private ThymeleafProperties properties;
 
 		@Autowired
 		private final ResourceLoader resourceLoader = new DefaultResourceLoader();
 
-
 		@PostConstruct
 		public void checkTemplateLocationExists() {
 			Boolean checkTemplateLocation = this.properties.isCheckTemplateLocation();
 			if (checkTemplateLocation) {
-				Resource resource = this.resourceLoader.getResource(this.properties.getPrefix());
+				Resource resource = this.resourceLoader.getResource(this.properties
+						.getPrefix());
 				Assert.state(resource.exists(), "Cannot find template location: "
 						+ resource + " (please add some templates "
 						+ "or check your Thymeleaf configuration)");
@@ -126,71 +128,71 @@ public static class ThymeleafProperties {
 		private String[] excludedViewNames;
 
 		public boolean isCheckTemplateLocation() {
-			return checkTemplateLocation;
+			return this.checkTemplateLocation;
 		}
 
 		public void setCheckTemplateLocation(boolean checkTemplateLocation) {
 			this.checkTemplateLocation = checkTemplateLocation;
 		}
 
 		public String getPrefix() {
-			return prefix;
+			return this.prefix;
 		}
 
 		public void setPrefix(String prefix) {
 			this.prefix = prefix;
 		}
 
 		public String getSuffix() {
-			return suffix;
+			return this.suffix;
 		}
 
 		public void setSuffix(String suffix) {
 			this.suffix = suffix;
 		}
 
 		public String getMode() {
-			return mode;
+			return this.mode;
 		}
 
 		public void setMode(String mode) {
 			this.mode = mode;
 		}
 
 		public String getEncoding() {
-			return encoding;
+			return this.encoding;
 		}
 
 		public void setEncoding(String encoding) {
 			this.encoding = encoding;
 		}
 
 		public String getContentType() {
-			return contentType;
+			return this.contentType;
 		}
 
 		public void setContentType(String contentType) {
 			this.contentType = contentType;
 		}
 
 		public boolean isCache() {
-			return cache;
+			return this.cache;
 		}
 
 		public void setCache(boolean cache) {
 			this.cache = cache;
 		}
 
 		public String[] getExcludedViewNames() {
-			return excludedViewNames;
+			return this.excludedViewNames;
 		}
 
 		public void setExcludedViewNames(String[] excludedViewNames) {
 			this.excludedViewNames = excludedViewNames;
 		}
 
 		public String[] getViewNames() {
-			return viewNames;
+			return this.viewNames;
 		}
 
 		public void setViewNames(String[] viewNames) {
@@ -234,14 +236,35 @@ public LayoutDialect layoutDialect() {
 
 	}
 
+	@Configuration
+	@ConditionalOnClass(DataAttributeDialect.class)
+	protected static class DataAttributeDialectConfiguration {
+
+		@Bean
+		public DataAttributeDialect dialect() {
+			return new DataAttributeDialect();
+		}
+
+	}
+
+	@Configuration
+	@ConditionalOnClass({ SpringSecurityDialect.class })
+	protected static class ThymeleafSecurityDialectConfiguration {
+
+		@Bean
+		public SpringSecurityDialect securityDialect() {
+			return new SpringSecurityDialect();
+		}
+
+	}
+
 	@Configuration
 	@ConditionalOnClass({ Servlet.class })
 	protected static class ThymeleafViewResolverConfiguration {
 
 		@Autowired
 		private ThymeleafProperties properties;
 
-
 		@Autowired
 		private SpringTemplateEngine templateEngine;
 
@@ -270,15 +293,4 @@ private String appendCharset(String type, String charset) {
 
 	}
 
-	@Configuration
-	@ConditionalOnClass({ SpringSecurityDialect.class })
-	protected static class ThymeleafSecurityDialectConfiguration {
-
-		@Bean
-		public SpringSecurityDialect securityDialect() {
-			return new SpringSecurityDialect();
-		}
-
-	}
-
 }

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/thymeleaf/ThymeleafAutoConfigurationTests.java

@@ -137,4 +137,15 @@ public void createLayoutFromConfigClass() throws Exception {
 		context.close();
 	}
 
+	@Test
+	public void useDataDialect() throws Exception {
+		this.context.register(ThymeleafAutoConfiguration.class,
+				PropertyPlaceholderAutoConfiguration.class);
+		this.context.refresh();
+		TemplateEngine engine = this.context.getBean(TemplateEngine.class);
+		Context attrs = new Context(Locale.UK, Collections.singletonMap("foo", "bar"));
+		String result = engine.process("data-dialect", attrs);
+		assertEquals("<html><body data-foo=\"bar\"></body></html>", result);
+	}
+
 }

spring-boot-autoconfigure/src/test/resources/templates/data-dialect.html

@@ -0,0 +1 @@
+<html><body data:foo="${foo}"></body></html>

spring-boot-dependencies/pom.xml

@@ -115,6 +115,7 @@
 		<thymeleaf.version>2.1.3.RELEASE</thymeleaf.version>
 		<thymeleaf-extras-springsecurity3.version>2.1.1.RELEASE</thymeleaf-extras-springsecurity3.version>
 		<thymeleaf-layout-dialect.version>1.2.5</thymeleaf-layout-dialect.version>
+		<thymeleaf-extras-data-attribute.version>1.3</thymeleaf-extras-data-attribute.version>
 		<tomcat.version>7.0.54</tomcat.version>
 		<velocity.version>1.7</velocity.version>
 		<velocity-tools.version>2.0</velocity-tools.version>
@@ -401,6 +402,11 @@
 				<artifactId>gemfire</artifactId>
 				<version>${gemfire.version}</version>
 			</dependency>
+			<dependency>
+				<groupId>com.github.mxab.thymeleaf.extras</groupId>
+				<artifactId>thymeleaf-extras-data-attribute</artifactId>
+				<version>${thymeleaf-extras-data-attribute.version}</version>
+			</dependency>
 			<dependency>
 				<groupId>com.h2database</groupId>
 				<artifactId>h2</artifactId>