Thymeleaf Date Dialect Bean in ThymeleafAutoConfiguration

[mxab]

Hi I added the DataAttributeDialect to ThymeleafAutoConfiguration

[dsyer]

I think you can use value= here (and the class literal)

[dsyer]

Thanks! I added a small comment on one line. We have to decide if it's OK to add a new dependency in 1.1.* or if it's better to wait till 1.2. Probably @wilkinsona will have the key opinion and he's on PTO at the moment.

[mxab]

Hey thanks, I thought also that the class makes more sense at that point, but the ThymeleafWebLayoutConfiguration had it also via the name=".." attribute so I thought I make it analog to that.

One more issue I have is if I should use @ConditionalOnMissingBean(DataAttributeDialect.class) since application that have already declared a DataAttributeDialect bean would have two then? (i.e. sagan)

[dsyer]

I think value= is OK at the type level, so I assume ThymeleafWebLayoutConfiguration is being over cautious (you should be able to test it by running a sample app that doesn't have the class but is a Thymeleaf app).

@ConditionalOnMissingBean defaults to the type of the @Bean it is decorating, so you might be able to skip that. Testing with Sagan is always a good idea.

[mxab]

I changed it to the class literal, further I included it in the thymeleaf starter dependencies and extended the spring-boot-sample-web-ui example project by some simple data dialect usage

[wilkinsona]

We have to decide if it's OK to add a new dependency in 1.1.* or if it's better to wait till 1.2

I'd prefer that we wait for 1.2

[dsyer]

Daniel Fernandez (Thymeleaf lead) has some concerns about this dialect, so I'm not sure we want it to be part of the starter. I know it is in use in Sagan, so I have no problem with including autoconfiguration, but maybe you should contact Daniel and discuss his concerns anyway (I'd be happy to set that up if I knew your email address).

[mxab]

I thought already that I went to far by including it in the starter :) I'll remove it. I have Daniels email address and will contact him.

[mxab]

Ok I reverted the last commit

[wilkinsona]

Master's building 1.2 now so we can start thinking about merging this. @mxab have you signed the CLA?

[mxab]

yep signed it

[wilkinsona]

Squashed and merged. Thanks for the contribution, @mxab.