Migrate to the connected app service #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type-infra
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
Co-authored-by: Kenzie Davisson <[email protected]>
…connected-app-service
kenzieschmoll
approved these changes
Jun 30, 2025
|
|
||
| Future<void> _listenForConnectedAppServiceEvents() async { | ||
| final dtd = _dtd!; | ||
| dtd.onVmServiceUpdate().listen((e) async { |
There was a problem hiding this comment.
do we need to cancel these listeners in some dispose method?
There was a problem hiding this comment.
We could, but it's not necessary. We keep listening as long as the DTD instance itself is still alive. If that does shut down, this stream will be closed.
| @@ -807,10 +796,10 @@ class _AppErrorsListener { | |||
| final StreamController<String> _errorsController; | |||
|
|
|||
| /// The listener for Flutter.Error vm service extension events. | |||
| final StreamSubscription<Event> _extensionEventsListener; | |||
| final StreamSubscription<Event>? _extensionEventsListener; | |||
There was a problem hiding this comment.
where are these stream subscriptions set?
There was a problem hiding this comment.
Just normally via the constructor - they aren't late, just nullable. They are created as a part of the forVmService static method which passes them into the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #198
This does drop all support for connecting to apps on SDKs that don't have this service, and I bumped the min SDK accordingly.