Skip to content

Add CODEOWNERS file #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025
Merged

Add CODEOWNERS file #877

merged 5 commits into from
Apr 3, 2025

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Apr 2, 2025

According to internal go/dart-package-ownership


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested review from munificent, devoncarew and lrhn April 2, 2025 06:44
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Apr 2, 2025
@mosuem mosuem changed the title Add CODEOWNERS file Add CODEOWNERS file Apr 2, 2025
Copy link

github-actions bot commented Apr 2, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@mosuem mosuem enabled auto-merge (squash) April 3, 2025 13:07
@mosuem mosuem merged commit 7a80178 into main Apr 3, 2025
11 checks passed
@mosuem mosuem deleted the addCodeOwners branch April 3, 2025 16:12
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 3, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/a6e81e0..7a80178):
  7a80178c  2025-04-03  Moritz  Add `CODEOWNERS` file (dart-lang/core#877)

dartdoc (https://github.com/dart-lang/dartdoc/compare/cbc1885..62aefbb):
  62aefbb7  2025-04-01  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/dartdoc#4029)

http (https://github.com/dart-lang/http/compare/e988925..32d5ffc):
  32d5ffc  2025-04-02  Moritz  Merge pull request `#1745` from dart-lang/revTo3
  1cc17f8  2025-04-02  Moritz  Merge pull request `#1743` from ueman/readme-fix
  4afc7f4  2025-04-02  Moritz  Add changelog entry
  c18d55d  2025-04-02  Moritz  Fix CI
  0e094cc  2025-04-02  Moritz  Update to Dart `3.7.0`
  2132038  2025-03-31  Jonas Uekötter  Update README.md

i18n (https://github.com/dart-lang/i18n/compare/2701040..de19436):
  de19436  2025-04-02  Moritz  Add `CODEOWNERS` (dart-lang/i18n#961)

protobuf (https://github.com/dart-lang/protobuf/compare/cf4f3a8..1aaa332):
  1aaa332  2025-04-01  dependabot[bot]  Bump actions/cache from 4.2.2 to 4.2.3 (google/protobuf.dart#972)

Change-Id: I183a6f902b8620e685f957f6a3d7d27e8bfcef4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420161
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
lrhn pushed a commit that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants