Skip to content

[path] Fix test race condition caused by changing Directory.current #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jensjoha
Copy link
Contributor

@jensjoha jensjoha commented May 7, 2025

Fixes #889.

@jensjoha jensjoha requested a review from a team as a code owner May 7, 2025 06:56
@jensjoha
Copy link
Contributor Author

jensjoha commented May 7, 2025

When reviewing do use the "hide whitespace" option as most of the "change" is whitespace changes caused by the removal of the try/finally.

Copy link

github-actions bot commented May 7, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
path None 1.9.1 1.9.2-wip 1.9.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
path InternalStyle

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@jensjoha jensjoha merged commit 816cea7 into dart-lang:main May 8, 2025
14 checks passed
@jensjoha jensjoha deleted the fix_test_race_condition_based_on_directory_current branch May 9, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running "dart test" inside "core/pkgs/path" has race condition and sporadic failures
2 participants