[native_assets_cli] Cleanup JSON: Code Asset OS and Architecture

[dcharkes]

Bug:

• [native_assets_cli] Remove fallback JSON encodings #2199

Cleanup from:

• [native_assets_cli] Remove OS and architecture from CodeAsset #2127

[github-actions]

PR Health

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
native_assets_builder	Breaking	0.16.0	0.17.0-wip	0.17.0	✔️
native_assets_cli	Breaking	0.16.0	0.17.0-wip	0.17.0	✔️
native_toolchain_c	Non-Breaking	0.13.0	0.14.0-wip	0.13.1	✔️

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

[coveralls]

coverage: 85.486% (+0.09%) from 85.396%
when pulling 7144cf9 on json-cleanup-code-asset
into 3add31b on main.

[goderbauer]

LGTM

[goderbauer]

Nit: This blank line here seems out of place?

[dcharkes]

Hm, this is what the formatter does. (Hence why our CI doesn't turn red.) cc @munificent

[goderbauer]

Same here and in other places of this file - I would have expected the formatter to catch and correct this? I am surprised that no check turned red?

[munificent]

I believe the formatter allows a blank line inside an argument list (maybe you want to group a few arguments together, similar to elements in a collection). But it should never insert one itself.

[dcharkes]

I see, I'd expect no blank lines. (This is how the previous formatter worked?) e.g. if I regex remove an argument from the list I wasn't including the new lines before.

[munificent]

(This is how the previous formatter worked?)

Yeah, the old formatting style made a bigger distinction between how argument lists and collection literals were formatted. The former didn't allow newlines but the latter did. In the new formatter, since both are formatted in a similar style, they reuse a lot of the same formatting logic and behave more similarly, including allowing newlines inside them.