Skip to content

[jnigen] Add regression tests for native/#693 and clean up TODOs #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

HosseinYousefi
Copy link
Member

Closes #693. This issue appears to be fixed by one of the other changes already, added a specific regression test for it and removed the related TODOs.

Copy link

github-actions bot commented May 9, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 84.5% (+2.8%) from 81.696%
when pulling 5141e4c on fix-693
into 6db256e on main.

@HosseinYousefi HosseinYousefi merged commit e8d1e39 into main May 9, 2025
36 checks passed
@HosseinYousefi HosseinYousefi deleted the fix-693 branch May 9, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descriptor doesn't represent the actual type edge case
3 participants