Handle 0 downloads in growth function #8741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
May 7, 2025
| @@ -35,6 +35,10 @@ double computeRelativeGrowthRate(List<int> totalDownloads) { | |||
| recentDownloads.reduce((prev, element) => prev + element) / | |||
| recentDownloads.length; | |||
|
|
|||
| if (averageRecentDownloads == 0) { | |||
There was a problem hiding this comment.
< 1 might also be worth considering...
Packages with average downloads less than one shouldn't have their growthrate increased..
There was a problem hiding this comment.
I'll keep it in mind but I'll keep it as it is for now. This is the mathematically correct calculation, and hence keeps the abstraction of the function clear. On the caller site we will handle packages with few downloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.