refactor: separate Raft API and impl #1367
Merged
+800
−503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmingdrmer
force-pushed
the
205-reduce-error
branch
from
7f032ff to
86ae355
Compare
For development concerns, we've separated the API interface from its implementation. During this refactoring, we maintained backward compatibility - the user-facing API remains unchanged. We kept the Raft struct as an API layer providing consistent methods, while moving all implementation details into several other structures. These implementation structures focus solely on core functionality, with the Raft API methods calling them and handling any necessary type conversions. This separation creates a clearer view of the implementation with a one-way contract, ensuring the user API remains stable and unaffected.
drmingdrmer
force-pushed
the
205-reduce-error
branch
from
86ae355 to
53477fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
refactor: separate Raft API and impl
For development concerns, we've separated the API interface from its implementation.
During this refactoring, we maintained backward compatibility - the user-facing API
remains unchanged. We kept the Raft struct as an API layer providing consistent methods,
while moving all implementation details into several other structures. These implementation
structures focus solely on core functionality, with the Raft API methods calling them and
handling any necessary type conversions. This separation creates a clearer view of the
implementation with a one-way contract, ensuring the user API remains stable and unaffected.
This change is