dbeaver/pro#6075 remove commit hooks #3548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
reviewed
Jun 25, 2025
Comment on lines
-25
to
-26
| "version:set": "yarn workspaces foreach -Ap --include '@cloudbeaver/product-*' run version:set", | ||
| "postinstall": "[ -z $CI ] && yarn lefthook install || true" |
There was a problem hiding this comment.
Do we really want to remove it completely, or should we just add a special command so only frontend developers can install it?
There was a problem hiding this comment.
Yeah, I suggest to:
- Rename the command to something like
install-lefthookso that yarn does not execute this command after installation of the deps - Add a VSCode task
- Add to the frontend guide that after all installations, we need to execute this task so the hook works for frontend devs
There was a problem hiding this comment.
But before we do that, is there any chance to fix some config so the hook works only for frontend-specific files: ts, tsx, CSS, etc., but never throws anything for the backend developers?
sergeyteleshev
approved these changes
Jul 7, 2025
|
cool! nice solution |
Wroud
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes 6075
Special flags were added (merge, rebase) to disable pre-commit hooks during the merge and rebase stages. Postinstall script will be executed anyway due to issue so no need to keep it in the package json