dbeaver/pro#6150 sync options part #3577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
approved these changes
Jul 9, 2025
Comment on lines
+52
to
+58
| useExecutor({ | ||
| executor: optionsPart.onDriverIdChange, | ||
| handlers: [ | ||
| function handleDriverChange() { | ||
| state.reset(); | ||
| }, | ||
| ], |
There was a problem hiding this comment.
This may not work if the component is unmounted (when the options tab is active)
There was a problem hiding this comment.
Agree, seems like it is better to do it inside the part
There was a problem hiding this comment.
We dont have access to this state in part, it exists only on the component level, because of this we dont want to run it if the component is ummounted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes 6150
Two additional bugs were fixed as part of this ticket:
If custom properties were defined and any changes were made to the connection options without visiting the Properties tab, all custom properties were deleted.
If custom properties were created and the driver was changed, the properties remained persistent across drivers.