Skip to content

Commit 4d6508f

Browse files
thomaswzallarak
authored andcommitted
Fix broken test suite (plaid#68)
* gitignore: add .cache directory * travis: remove pre-release python 3.5 versions * travis: use the project make script * requirements: bump pytest reqs for py3.5 compat The 3.x branch of pytest drops support for <3.3 which, according, to the travis file, this project still supports. As a consequence of that, we can only go up to pytest 2.9.2. * setup.py: add python 3.5 trove classifier This project is tested in that environment. * client tests: correct ResourceNotFound testing test_ResourceNotFound_connect was checking for a ResourceNotFoundError on an operation that should actually succeed. This modifies that operation so that it will fail as expected.
1 parent 78ea31e commit 4d6508f

File tree

5 files changed

+11
-12
lines changed

5 files changed

+11
-12
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ pip-log.txt
2525
# Unit test / coverage reports
2626
.coverage
2727
.tox
28+
.cache
2829
nosetests.xml
2930

3031
# Translations

.travis.yml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,10 @@ python:
77
- "3.2"
88
- "3.3"
99
- "3.4"
10-
- "3.5.0b3"
11-
- "3.5-dev"
12-
- "nightly"
13-
10+
- "3.5"
1411
install:
15-
- "pip install -r requirements.txt"
16-
- "pip install flake8"
17-
18-
becore_script: "flake8 plaid tests"
19-
script: nosetests
12+
- "make setup"
13+
becore_script:
14+
- "make lint"
15+
script:
16+
- "make test"

requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ cov-core==1.7
66
coverage==3.7.1
77
flake8==2.4.1
88
mock==1.0.1
9-
py==1.4.20
10-
pytest==2.5.2
9+
py==1.4.32
10+
pytest==2.9.2
1111
pytest-cov==1.6

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
"Programming Language :: Python :: 2.7",
2727
"Programming Language :: Python :: 3",
2828
"Programming Language :: Python :: 3.4",
29+
"Programming Language :: Python :: 3.5",
2930
"Topic :: Software Development :: Libraries :: Python Modules",
3031
"Environment :: Web Environment",
3132
]

tests/integration/test_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def test_unauthorizedError_bad_password():
311311
def test_ResourceNotFound_connect():
312312
client = Client('test_id', 'test_secret')
313313
with pytest.raises(ResourceNotFoundError):
314-
client.connect('pnc', no_mfa_credentials)
314+
client.connect('notpnc', no_mfa_credentials)
315315

316316

317317
def test_ResourceNotFound_categories():

0 commit comments

Comments
 (0)