Fix broken test suite #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 3.x branch of pytest drops support for <3.3 which, according, to the travis file, this project still supports. As a consequence of that, we can only go up to pytest 2.9.2.
This project is tested in that environment.
test_ResourceNotFound_connect was checking for a ResourceNotFoundError on an operation that should actually succeed. This modifies that operation so that it will fail as expected.
|
Thanks so much for doing this @thomasw - will merge now! |
|
❤️ 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite would not run under python 3.5 due to pytest incompatibilities. Additionally, the travis config for this project no longer appears to be valid which this pull also corrects.
Once I had the test suite running, I discovered a bad test which was failing. I've corrected that test so that it verifies the expected behavior and passes.