-
Notifications
You must be signed in to change notification settings - Fork 84
[6.6] HYGON: Add new pci device id and modify psp_do_cmd() interface #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to not rely on sev device hygon inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/IC7KDI CVE: NA --------------------------- add new psp/ccp device id and modify psp_do_cmd() interface to not rely on sev device. Signed-off-by: chench <[email protected]>
…ufficient array size In the function 'int sprint_symbol(char *buffer, unsigned long address)', the buffer variable will undergo a write operation "namebuf[KSYM_NAME_LEN - 1] = 0;" during the following call chain. Call Trace: tdm_get_cmd_context_hash -> sprint_symbol -> __sprint_symbol -> kallsyms_lookup_buildid Therefore, it is mandatory to ensure the buffer has a minimum size of KSYM_NAME_LEN. Signed-off-by: chench <[email protected]>
Reviewer's GuideThis PR decouples PSP command execution from the SEV device by introducing a dedicated wait queue and command-wait helper, updates the IRQ handler and header accordingly, adds two new Hygon PCI device IDs, and fixes an out-of-bounds buffer in the TDM driver. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Hi @chench246. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chench246 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: opsiff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reference: https://gitee.com/openeuler/kernel/pulls/16281
Summary by Sourcery
Add new Hygon PCI device IDs, decouple PSP command execution from SEV, and correct TDM driver buffer sizing to avoid memory overflows.
New Features:
Bug Fixes:
Enhancements: