Skip to content

HAOC: CREDP: Fix build error when CREDP is off #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: linux-6.6.y
Choose a base branch
from

Conversation

amjac27
Copy link
Contributor

@amjac27 amjac27 commented May 15, 2025

CRED_DATA is not defined in vmlinux.lds.S when CREDP is not defined, which could lead to build error. Fix this problem both in X86 and ARM64.

Summary by Sourcery

Bug Fixes:

  • Prevent undefined CRED_DATA in vmlinux.lds.S by providing an empty definition when CONFIG_CREDP is off

`CRED_DATA` is not defined in vmlinux.lds.S when CREDP is not
defined, which could lead to build error. Fix this problem both in
X86 and ARM64.

Signed-off-by: Liu Zhehui <[email protected]>
Copy link

sourcery-ai bot commented May 15, 2025

Reviewer's Guide

Introduce a fallback definition for CRED_DATA in the kernel linker scripts for both ARM64 and x86 when CREDP is disabled to prevent build errors.

File-Level Changes

Change Details Files
Add fallback definition for CRED_DATA when CREDP is disabled
  • Insert #else block with #define CRED_DATA in the ARM64 vmlinux.lds.S linker script
  • Insert #else block with #define CRED_DATA in the x86 vmlinux.lds.S linker script
arch/arm64/kernel/vmlinux.lds.S
arch/x86/kernel/vmlinux.lds.S

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot deepin-ci-robot requested review from BLumia and Wenlp May 15, 2025 09:25
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign avenger-285714 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @amjac27. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amjac27 - I've reviewed your changes - here's some feedback:

  • Consider consolidating the empty CRED_DATA stub into a shared header or macro to avoid duplicating the same #define across ARM64 and x86 vmlinux.lds.S files.
  • Make sure to apply the same empty CRED_DATA definition to any other architectures (e.g. MIPS, PowerPC) that include vmlinux.lds.S to prevent similar build failures when CONFIG_CREDP is off.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants