-
Notifications
You must be signed in to change notification settings - Fork 84
HAOC: CREDP: Fix build error when CREDP is off #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: linux-6.6.y
Are you sure you want to change the base?
Conversation
`CRED_DATA` is not defined in vmlinux.lds.S when CREDP is not defined, which could lead to build error. Fix this problem both in X86 and ARM64. Signed-off-by: Liu Zhehui <[email protected]>
Reviewer's GuideIntroduce a fallback definition for CRED_DATA in the kernel linker scripts for both ARM64 and x86 when CREDP is disabled to prevent build errors. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @amjac27. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @amjac27 - I've reviewed your changes - here's some feedback:
- Consider consolidating the empty CRED_DATA stub into a shared header or macro to avoid duplicating the same #define across ARM64 and x86 vmlinux.lds.S files.
- Make sure to apply the same empty CRED_DATA definition to any other architectures (e.g. MIPS, PowerPC) that include vmlinux.lds.S to prevent similar build failures when CONFIG_CREDP is off.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
CRED_DATA
is not defined in vmlinux.lds.S when CREDP is not defined, which could lead to build error. Fix this problem both in X86 and ARM64.Summary by Sourcery
Bug Fixes: