-
Notifications
You must be signed in to change notification settings - Fork 84
cpufreq: phytium: bugfix the null pointer of boost in high temperature #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: linux-6.6.y
Are you sure you want to change the base?
cpufreq: phytium: bugfix the null pointer of boost in high temperature #809
Conversation
Fix that when the temperature cotrol module determines whether boost is supported of not in a high temperature enviroment and boost is not enabled, the error code will be retured because the cpufreq_driver module is not initialized, resulting in entering the cpufreq module and writing a value to it, and a null pointer error will be reported. Signed-off-by: Jiakun Shuai <[email protected]>
Reviewer's GuideError paths in CPU frequency boost support now return false instead of an error code when the driver isn’t initialized, preventing null pointer dereferences in high-temperature scenarios. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @JiakunShuai. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JiakunShuai - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Fix that when the temperature cotrol module determines whether boost is supported of not in a high temperature enviroment and boost is not enabled, the error code will be retured because the cpufreq_driver module is not initialized, resulting in entering the cpufreq module and writing a value to it, and a null pointer error will be reported.
Summary by Sourcery
Bug Fixes: