-
Notifications
You must be signed in to change notification settings - Fork 92
riscv:defconfig: enable zstd/xz support for fw loader #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riscv:defconfig: enable zstd/xz support for fw loader #869
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables Zstandard (zstd) compression support for the firmware loader in the Deepin RISC-V64 desktop defconfig.
- Add
CONFIG_FW_LOADER_COMPRESS_ZSTD
to enable zstd decompression in the firmware loader. - Ensures that zstd support is built alongside existing firmware compression mechanisms.
Comments suppressed due to low confidence (2)
arch/riscv/configs/deepin_riscv64_desktop_defconfig:599
- [nitpick] Consider updating the relevant Kconfig help text or driver documentation to mention that zstd support is now available for firmware loading.
CONFIG_FW_LOADER_COMPRESS_ZSTD=y
arch/riscv/configs/deepin_riscv64_desktop_defconfig:599
- Align the indentation of this new option with surrounding lines (add leading spaces) for consistency with other config entries.
CONFIG_FW_LOADER_COMPRESS_ZSTD=y
aa3276d
to
ccd09da
Compare
deepin pr auto review在提供的代码更改中,添加了两个新的配置选项 代码质量
代码性能
代码安全
其他建议
总体来说,这个更改看起来是为了提高固件加载的性能和效率,但需要确保相关的安全性和性能测试都已经到位。 |
Signed-off-by: Yukari Chiba <[email protected]>
ccd09da
to
c1a546f
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: opsiff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reviewer's GuideUpdates the RISC-V desktop defconfig to enable zstd and xz decompression in the firmware loader by setting the corresponding config flags. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary by Sourcery
Enable zstd and xz support for the firmware loader in the RISC-V desktop defconfig
Enhancements: