Skip to content

CI: check-config: add ACPI_DEBUG to generic whitelist #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Jun 12, 2025

Some x86 ArrowLake laptop device boot depends on the config. We have no device, but user says okay, so just enable it. DMI: LENOVO 21TU/LNVNB161216, BIOS RJCN20WW

Link:https://bbs.deepin.org/zh/post/288038?offset=0&postId=1722190
Link:https://discourse.nixos.org/t/system-wont-boot-path-efi-stub/29212/30

Summary by Sourcery

CI:

  • Add CONFIG_ACPI_DEBUG to generic_config_whitelist in the check-config workflow

Some x86 ArrowLake laptop device boot depends on the config.
We have no device, but user says okay, so just enable it.
DMI: LENOVO 21TU/LNVNB161216, BIOS RJCN20WW

Link:https://bbs.deepin.org/zh/post/288038?offset=0&postId=1722190
Link:https://discourse.nixos.org/t/system-wont-boot-path-efi-stub/29212/30

Signed-off-by: Wentao Guan <[email protected]>
Copy link

sourcery-ai bot commented Jun 12, 2025

Reviewer's Guide

Update CI config by whitelisting the ACPI_DEBUG kernel symbol in the generic config checker.

File-Level Changes

Change Details Files
Whitelist ACPI_DEBUG in generic CI config checks
  • Added "ACPI_DEBUG" to the generic_config_whitelist file
.github/workflows/generic_config_whitelist

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714 Avenger-285714 merged commit 2a7b394 into deepin-community:linux-6.6.y Jun 12, 2025
7 of 8 checks passed
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds CONFIG_ACPI_DEBUG to the CI’s generic whitelist to enable boot support for certain ArrowLake x86 laptops.

  • Include a descriptive comment linking to the upstream kernel PR.
  • Whitelist CONFIG_ACPI_DEBUG in .github/workflows/generic_config_whitelist.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @opsiff - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@opsiff opsiff deleted the linux-6.6.y-2025-06-12-ci branch June 13, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants